Extremely doubtful IF

[Diego_Mello]

I found this this morning ...

Select all

 
function CF_TOTAL_PARESFormula return Number is 
  vtotal_pares  number(8); 
begin 
  if :pares_linha > 0 then 
    vtotal_pares := :pares_linha; 
  else 
    vtotal_pares := 0; 
  end if;   
  if vtotal_pares = 0 then 
    return(0); 
  else 
    return(vtotal_pares); 
  end if;   
end;       

[DanielNN]

Apparently, the person who was testing wanted it to be assigned the value 0.
What is cooler is not having another if but the other is completely dispensable.
to make a simple return (v_total_par).
If you can see if it is 0 variable, return 0:

Select all

  if vtotal_pares = 0 then 
    return(0); 
  else 
    return(vtotal_pares); 
  end if;  

[Diego_Mello]

It is neither the question of avoiding negative pairs.
Thinking a little more on business rule, it is impossible to have negative pairs.
Soon, the solution would be very, but much simpler.

Select all

 RETURN NVL(:pares_linha, 0);

and if you want to simplify even more, simply put the NVL straight into Query: P

[dr_gori]

From what I understood, if the number is negative, you have to go to zero.

Then something like this:

Select all

IF :pares_linha <= 0  --Se for menor que zero, retorna zero. 
THEN return 0; 
ELSE return :pares_linha;   --Senão, retorna o próprio numero. 
END IF;

or, can do in a line only:

Select all

RETURN  DECODE ( SIGN(:pares_linha), -1, 0, :pares_linha)

[dr_gori]

It is impossible to have negative pairs.

is right

[DanielNN]

Truth. Of course there should be no negative. But coming from this IF there, does anyone still doubt any negative pairs ???
Hehehehehhe.

[Diego_Mello]

Auheuaheuahe: P

[dr_gori]

Interesting how much interpretation can generate a doubtful code without comments ... That's where we waste time, trying to guess what's on the head of the guy who did ..: roll: